Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null return from grgit.describe #152

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Handle null return from grgit.describe #152

merged 3 commits into from
Oct 26, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

When building this project, I encountered the following issue:

$ ./gradlew build

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/jtraglia/Projects/jtraglia/discv5-java/build.gradle' line: 214

* What went wrong:
A problem occurred evaluating root project 'discovery'.
> Cannot invoke method contains() on null object

The return value of grgit.describe is null and this is causing problems.

This PR copies what Teku does in calculateVersion:

ajsutton
ajsutton approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajsutton ajsutton merged commit 4dd2abf into Consensys:master Oct 26, 2022
@jtraglia jtraglia deleted the check-if-version-is-null branch October 26, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @ajsutton